PARQUET-540: Fix Cascading 3 build thrift and SLF4J. #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
PARQUET-540-fix-cascading3-build
branch
from
a382668 to
de2eb01
Compare
This also updates the build to use the public maven-thrift-plugin, which is version 0.1.11.
rdblue
force-pushed
the
PARQUET-540-fix-cascading3-build
branch
from
de2eb01 to
c976e04
Compare
Contributor
Author
|
@danielcweeks, can you take a look at this? Thanks! |
Contributor
Author
|
@julienledem, can you look at this? Cascading 3 broke the build for thrift 9. This fixes the problem. Thanks! |
parquet-cascading/pom.xml
Outdated
| <groupId>org.apache.thrift.tools</groupId> | ||
| <artifactId>maven-thrift-plugin</artifactId> | ||
| <version>0.1.10</version> | ||
| <version>0.1.11</version> |
There was a problem hiding this comment.
pull this version constant out to the root pom file?
|
minor comment, apart from that lgtm |
Contributor
Author
|
@julienledem, since you're reviewing today, could you take a quick look at this one? It's a big annoyance. :) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: